Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: avoid infinite loop with React 19 and StrictMode #2933

Merged
merged 11 commits into from
Jan 31, 2025
Merged

test: avoid infinite loop with React 19 and StrictMode #2933

merged 11 commits into from
Jan 31, 2025

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Jan 14, 2025 •
edited
Loading

Related Bug Reports or Discussions

Fixes #2931

  • show the working pattern as tests

Summary

Check List

  • pnpm run fix:format for formatting code and docs

@vercel Vercel
Copy link

vercel bot commented Jan 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 0:19am

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jan 14, 2025 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 14, 2025 •
edited
Loading

Open in Stackblitz

More templates

npm i https://pkg.pr.new/jotai@2933

commit: deabc9d

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 14, 2025 •
edited
Loading

Size Change: 0 B

Total Size: 92.1 kB

ℹ️ View Unchanged
Filename Size
./dist/babel/plugin-debug-label.js 933 B
./dist/babel/plugin-react-refresh.js 1.14 kB
./dist/babel/preset.js 1.41 kB
./dist/esm/babel/plugin-debug-label.mjs 1 kB
./dist/esm/babel/plugin-react-refresh.mjs 1.2 kB
./dist/esm/babel/preset.mjs 1.49 kB
./dist/esm/index.mjs 62 B
./dist/esm/react.mjs 1.41 kB
./dist/esm/react/utils.mjs 747 B
./dist/esm/utils.mjs 67 B
./dist/esm/vanilla.mjs 4.21 kB
./dist/esm/vanilla/utils.mjs 5.05 kB
./dist/index.js 242 B
./dist/react.js 1.44 kB
./dist/react/utils.js 1.39 kB
./dist/system/babel/plugin-debug-label.development.js 1.11 kB
./dist/system/babel/plugin-debug-label.production.js 775 B
./dist/system/babel/plugin-react-refresh.development.js 1.3 kB
./dist/system/babel/plugin-react-refresh.production.js 928 B
./dist/system/babel/preset.development.js 1.59 kB
./dist/system/babel/preset.production.js 1.14 kB
./dist/system/index.development.js 252 B
./dist/system/index.production.js 183 B
./dist/system/react.development.js 1.56 kB
./dist/system/react.production.js 865 B
./dist/system/react/utils.development.js 859 B
./dist/system/react/utils.production.js 462 B
./dist/system/utils.development.js 257 B
./dist/system/utils.production.js 187 B
./dist/system/vanilla.development.js 4.3 kB
./dist/system/vanilla.production.js 2.19 kB
./dist/system/vanilla/utils.development.js 5.26 kB
./dist/system/vanilla/utils.production.js 3.15 kB
./dist/umd/babel/plugin-debug-label.development.js 1.07 kB
./dist/umd/babel/plugin-debug-label.production.js 852 B
./dist/umd/babel/plugin-react-refresh.development.js 1.27 kB
./dist/umd/babel/plugin-react-refresh.production.js 1 kB
./dist/umd/babel/preset.development.js 1.54 kB
./dist/umd/babel/preset.production.js 1.22 kB
./dist/umd/index.development.js 383 B
./dist/umd/index.production.js 328 B
./dist/umd/react.development.js 1.56 kB
./dist/umd/react.production.js 936 B
./dist/umd/react/utils.development.js 1.53 kB
./dist/umd/react/utils.production.js 1.01 kB
./dist/umd/utils.development.js 399 B
./dist/umd/utils.production.js 342 B
./dist/umd/vanilla.development.js 5.7 kB
./dist/umd/vanilla.production.js 2.85 kB
./dist/umd/vanilla/utils.development.js 6.25 kB
./dist/umd/vanilla/utils.production.js 3.78 kB
./dist/utils.js 247 B
./dist/vanilla.js 5.58 kB
./dist/vanilla/utils.js 6.11 kB

compressed-size-action

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 14, 2025 •
edited
Loading

LiveCodes Preview in LiveCodes

Latest commit: deabc9d
Last updated: Jan 31, 2025 12:18am (UTC)

Playground Link
React demo https://livecodes.io?x=id/5G3MAHF6M

See documentations for usage instructions.

@dai-shi dai-shi added this to the v2.11.1 milestone Jan 14, 2025
@dai-shi dai-shi removed this from the v2.11.1 milestone Jan 15, 2025
@dai-shi dai-shi changed the title fix: infinite loop with React 19 and StrictMode test: avoid infinite loop with React 19 and StrictMode Jan 20, 2025
@dai-shi dai-shi marked this pull request as ready for review January 31, 2025 00:19
@dai-shi dai-shi merged commit 4636c08 into main Jan 31, 2025
45 checks passed
@dai-shi dai-shi deleted the issue-2931 branch January 31, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dai-shi